[
https://issues.apache.org/jira/browse/ZOOKEEPER-1596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509361#comment-13509361
]
Hadoop QA commented on ZOOKEEPER-1596:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12555847/zookeeper-1596_v1.patch
against trunk revision 1415847.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1281//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1281//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1281//console
This message is automatically generated.
> Zab1_0Test should ensure that the file is closed
> ------------------------------------------------
>
> Key: ZOOKEEPER-1596
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1596
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.5.0, 3.4.5
> Reporter: Enis Soztutar
> Attachments: zookeeper-1596_v1.patch
>
>
> Zab1_0Test fails on windows with:
> {code}
> java.io.IOException: Could not rename temporary file
> C:\Users\ADMINI~1\AppData\Local\Temp\2\test6831881113551099349dir\version-2\acceptedEpoch.tmp
> to C:\Users\A
> DMINI~1\AppData\Local\Temp\2\test6831881113551099349dir\version-2\acceptedEpoch
> at
> org.apache.zookeeper.common.AtomicFileOutputStream.close(AtomicFileOutputStream.java:82)
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.writeLongToFile(QuorumPeer.java:1121)
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.setAcceptedEpoch(QuorumPeer.java:1148)
> at
> org.apache.zookeeper.server.quorum.Learner.registerWithLeader(Learner.java:281)
> at
> org.apache.zookeeper.server.quorum.Follower.followLeader(Follower.java:72)
> at
> org.apache.zookeeper.server.quorum.Zab1_0Test$1.run(Zab1_0Test.java:450)
> {code}
> The file handlers currentEpoch and acceptedEpoch are not closed, so delete
> fails on windows.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
