[
https://issues.apache.org/jira/browse/ZOOKEEPER-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528774#comment-13528774
]
Patrick Hunt edited comment on ZOOKEEPER-1574 at 12/11/12 7:53 AM:
-------------------------------------------------------------------
A couple other drawbacks:
2) this patch has the potential to cause existing patches created before this
one is committed to not apply cleanly. Similar problems in backporting changes
from trunk to branch 3.4 unless we also make similar changes on that branch. On
the bright side it's easy to resolve. Not sure the impact though in terms of
breadth.
3) keep in mind that the core repo is SVN, and not GIT. While git is available
it's read only. All commits go through SVN. Is there a way to fix (similar to
git attributed) this in SVN as well? Otherwise these same issues will keep
cropping up.
was (Author: phunt):
A couple other drawbacks:
2) this patch has the potential to cause existing patches created before this
one is committed to not apply cleanly. on the bright side it's easy to resolve.
not sure the impact though in terms of breadth.
3) keep in mind that the core repo is SVN, and not GIT. While git is available
it's read only. All commits go through SVN. Is there a way to fix (similar to
git attributed) this in SVN as well? Otherwise these same issues will keep
cropping up.
> mismatched CR/LF endings in text files
> --------------------------------------
>
> Key: ZOOKEEPER-1574
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1574
> Project: ZooKeeper
> Issue Type: Bug
> Reporter: Raja Aluri
> Assignee: Raja Aluri
> Attachments: ZOOKEEPER-1574.trunk.patch
>
>
> Source code in zookeeper repo has a bunch of files that have CRLF endings.
> With more development happening on windows there is a higher chance of more
> CRLF files getting into the source tree.
> I would like to avoid that by creating .gitattributes file which prevents
> sources from having CRLF entries in text files.
> But before adding the .gitattributes file we need to normalize the existing
> tree, so that people when they sync after .giattributes change wont end up
> with a bunch of modified files in their workspace.
> I am adding a couple of links here to give more primer on what exactly is the
> issue and how we are trying to fix it.
> [http://git-scm.com/docs/gitattributes#_checking_out_and_checking_in]
> [http://stackoverflow.com/questions/170961/whats-the-best-crlf-handling-strategy-with-git]
> I will submit a separate bug and patch for .gitattributes
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
