[
https://issues.apache.org/jira/browse/BOOKKEEPER-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13530227#comment-13530227
]
Ivan Kelly commented on BOOKKEEPER-365:
---------------------------------------
ah, so the test in BOOKKEEPER-355 and your test are different. I didn't go
through them line by line, as they looked very similiar, I thought you were
fixing 355 within this patch also. In that case, I have a preliminary patch for
355, ill post it tomorrow after I submit this.
{quote}
maxMissedReadsAllowed means the max number of NoSuchEntry reads happened in a
quorum. if this number is larger than (write_quorum_size - ack_quorum_size), it
means that the entry hasn't ack'ed successfully based on the guarantee provides
by 'ack_quorum'.{quote}
Ok, I understand now. If the number of NoSuchEntry is greater than the
difference between ack quorum and write quorum, then the ack quorum could never
have been completed. However, in your patch, you have
{code}
maxMissedReadsAllowed = lh.metadata.getWriteQuorumSize() -
lh.metadata.getAckQuorumSize() + 1;
{code}
Is the + 1 correct?
> Ledger will never recover if one of the quorum bookie is down forever and
> others dont have entry
> ------------------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-365
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-365
> Project: Bookkeeper
> Issue Type: Bug
> Affects Versions: 4.0.0, 4.1.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-365.diff
>
>
> As discussed in BOOKKEEPER-355, current fix to handle the below issue is not
> correct. Need to find out new solution
> If some bookies of a quorum gone forever, some bookies of this quorum are
> still alive but doesn't have that entry (NoSuchEntry or NoSuchLedger), then
> the ledger doesn't have any evidence to recovery/close it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
