[
https://issues.apache.org/jira/browse/ZOOKEEPER-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13532923#comment-13532923
]
Hadoop QA commented on ZOOKEEPER-1602:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12561087/ZOOKEEPER-1602.patch
against trunk revision 1422167.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1297//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1297//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1297//console
This message is automatically generated.
> a change to QuorumPeerConfig's API broke compatibility with HBase
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1602
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1602
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.5.0
> Reporter: Patrick Hunt
> Assignee: Alexander Shraer
> Priority: Blocker
> Labels: newbie
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1602.patch
>
>
> The following patch broke an API that's in use by HBase. Otherwise current
> trunk compiles fine when used by hbase:
> bq. ZOOKEEPER-1411. Consolidate membership management, distinguish between
> static and dynamic configuration parameters (Alex Shraer via breed)
> Considering it a blocker even though it's not really a "public" API. If
> possible we should add back "getServers" method on QuorumPeerConfig to reduce
> friction for the hbase team.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
