[
https://issues.apache.org/jira/browse/ZOOKEEPER-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13533333#comment-13533333
]
Hadoop QA commented on ZOOKEEPER-1593:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12561176/zookeeper_debian_default.patch
against trunk revision 1422473.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1301//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1301//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1301//console
This message is automatically generated.
> Add Debian style /etc/default/zookeeper support to init script
> --------------------------------------------------------------
>
> Key: ZOOKEEPER-1593
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1593
> Project: ZooKeeper
> Issue Type: Improvement
> Components: scripts
> Affects Versions: 3.4.5
> Environment: Debian Linux 6.0
> Reporter: Dirkjan Bussink
> Priority: Minor
> Attachments: zookeeper_debian_default.patch
>
>
> In our configuration we use a different data directory for Zookeeper. The
> problem is that the current Debian init.d script has the default location
> hardcoded:
> ZOOPIDDIR=/var/lib/zookeeper/data
> ZOOPIDFILE=${ZOOPIDDIR}/zookeeper_server.pid
> By using the standard Debian practice of allowing for a
> /etc/default/zookeeper we can redefine these variables to point to the
> correct location:
> ZOOPIDDIR=/var/lib/zookeeper/data
> ZOOPIDFILE=${ZOOPIDDIR}/zookeeper_server.pid
> [ -r /etc/default/zookeeper ] && . /etc/default/zookeeper
> This currently can't be done through /usr/libexec/zkEnv.sh, since that is
> loaded before ZOOPIDDIR and ZOOPIDFILE are set. Any change there would
> therefore undo the setup made in for example /etc/zookeeper/zookeeper-env.sh.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
