[
https://issues.apache.org/jira/browse/ZOOKEEPER-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13553396#comment-13553396
]
Alexander Shraer commented on ZOOKEEPER-1504:
---------------------------------------------
Hi Jay, Thawan,
I'm trying to adjust my ZK-107 patch to work with your change here,
specifically the ability to dynamically modify the port used by servers to
accept client connections. I had the following code in NioServerCnxnFactory,
that now no longer works:
+ public void reconfigure(InetSocketAddress addr){
+ ServerSocketChannel oldSS = ss;
+ try {
+ this.ss = ServerSocketChannel.open();
+ ss.socket().setReuseAddress(true);
+ LOG.info("binding to port " + addr);
+ ss.socket().bind(addr);
+ ss.configureBlocking(false);
+ ss.register(selector, SelectionKey.OP_ACCEPT);
+ oldSS.close();
+ } catch(IOException e) {
+ LOG.error("Error reconfiguring client port to " + addr + " " +
e.getMessage());
+ }
+ }
I'm trying to do something similar with your new code, but its more complex
because of the code in AcceptThread. I could change the port as above, create a
new AcceptThread and the current AcceptThread would kill itself because the old
socket is closed, but it would also take down the selectorthreads, which I
don't think we wanna do in this case. Can you please add a "reconfigure" method
to AcceptThread that gets a new ServerSocketChannel ss socket and changes the
AcceptThread accordingly ? or please advise on how I can do this correctly.
Thanks,
Alex
> Multi-thread NIOServerCnxn
> --------------------------
>
> Key: ZOOKEEPER-1504
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1504
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.4.3, 3.4.4, 3.5.0
> Reporter: Jay Shrauner
> Assignee: Jay Shrauner
> Labels: performance, scaling
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1504.patch, ZOOKEEPER-1504.patch,
> ZOOKEEPER-1504.patch, ZOOKEEPER-1504.patch, ZOOKEEPER-1504.patch,
> ZOOKEEPER-1504.patch
>
>
> NIOServerCnxnFactory is single threaded, which doesn't scale well to large
> numbers of clients. This is particularly noticeable when thousands of clients
> connect. I propose multi-threading this code as follows:
> - 1 acceptor thread, for accepting new connections
> - 1-N selector threads
> - 0-M I/O worker threads
> Numbers of threads are configurable, with defaults scaling according to
> number of cores. Communication with the selector threads is handled via
> LinkedBlockingQueues, and connections are permanently assigned to a
> particular selector thread so that all potentially blocking SelectionKey
> operations can be performed solely by the selector thread. An ExecutorService
> is used for the worker threads.
> On a 32 core machine running Linux 2.6.38, achieved best performance with 4
> selector threads and 64 worker threads for a 70% +/- 5% improvement in
> throughput.
> This patch incorporates and supersedes the patches for
> https://issues.apache.org/jira/browse/ZOOKEEPER-517
> https://issues.apache.org/jira/browse/ZOOKEEPER-1444
> New classes introduced in this patch are:
> - ExpiryQueue (from ZOOKEEPER-1444): factor out the logic from
> SessionTrackerImpl used to expire sessions so that the same logic can be used
> to expire connections
> - RateLogger (from ZOOKEEPER-517): rate limit error message logging,
> currently only used to throttle rate of logging "out of file descriptors"
> errors
> - WorkerService (also in ZOOKEEPER-1505): ExecutorService wrapper that
> makes worker threads daemon threads and names then in an easily debuggable
> manner. Supports assignable threads (as used by CommitProcessor) and
> non-assignable threads (as used here).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
