[ https://issues.apache.org/jira/browse/ZOOKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556501#comment-13556501 ]
Thawan Kooburat commented on ZOOKEEPER-107: ------------------------------------------- I was looking at the patch direct so I might miss understood some of the detail. I think you still need to close the selector when destroying the old acceptor thread (and possibly joining with the thread as well). reconfiguring flag is part of NIOConnectionFactory? then you will have to set it back to false when reconfiguration is done as well. > Allow dynamic changes to server cluster membership > -------------------------------------------------- > > Key: ZOOKEEPER-107 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-107 > Project: ZooKeeper > Issue Type: Improvement > Components: server > Reporter: Patrick Hunt > Assignee: Alexander Shraer > Fix For: 3.5.0 > > Attachments: SimpleAddition.rtf, zkreconfig-usenixatc-final.pdf, > ZOOKEEPER-107-14-Jan.patch, ZOOKEEPER-107-14-Oct.patch, > ZOOKEEPER-107-15-Oct.patch, ZOOKEEPER-107-15-Oct-ver1.patch, > ZOOKEEPER-107-15-Oct-ver2.patch, ZOOKEEPER-107-15-Oct-ver3.patch, > ZOOKEEPER-107-16-Jan.patch, ZOOKEEPER-107-1-Mar.patch, > ZOOKEEPER-107-20-July.patch, ZOOKEEPER-107-21-July.patch, > ZOOKEEPER-107-22-Apr.patch, ZOOKEEPER-107-23-SEP.patch, > ZOOKEEPER-107-28-Feb.patch, ZOOKEEPER-107-28-Feb.patch, > ZOOKEEPER-107-28-NOV-ver2.patch, ZOOKEEPER-107-29-Feb.patch, > ZOOKEEPER-107-3-Oct.patch, ZOOKEEPER-107-6-NOV-2.patch, > ZOOKEEPER-107-7-NOV.patch, ZOOKEEPER-107-7-NOV-ver1.patch, > ZOOKEEPER-107-7-NOV-ver2.patch, ZOOKEEPER-107-Aug-20.patch, > ZOOKEEPER-107-Aug-20-ver1.patch, ZOOKEEPER-107-Aug-25.patch, > zookeeper-3.4.0.jar, zookeeper-dev-fatjar.jar, > zookeeper-reconfig-sep11.patch, zookeeper-reconfig-sep12.patch, > zoo_replicated1.cfg, zoo_replicated1.members > > > Currently cluster membership is statically defined, adding/removing hosts > to/from the server cluster dynamically needs to be supported. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira