[
https://issues.apache.org/jira/browse/ZOOKEEPER-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560425#comment-13560425
]
Hadoop QA commented on ZOOKEEPER-1495:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12566097/ZOOKEEPER-1495.2.patch
against trunk revision 1437257.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The patch appears to cause tar ant target to fail.
-1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1354//testReport/
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1354//console
This message is automatically generated.
> ZK client hangs when using a function not available on the server.
> ------------------------------------------------------------------
>
> Key: ZOOKEEPER-1495
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1495
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.4.2, 3.3.5
> Environment: all
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 1495.br33.v3.patch, ZOOKEEPER-1495.2.patch,
> ZOOKEEPER-1495.patch
>
>
> This happens for example when using zk#multi with a 3.4 client but a 3.3
> server.
> The issue seems to be on the server side: the servers drops the packets with
> an unknown OpCode in ZooKeeperServer#submitRequest
> {noformat}
> public void submitRequest(Request si) {
> // snip
> try {
> touch(si.cnxn);
> boolean validpacket = Request.isValid(si.type); // ===> Check on case
> OpCode.*
> if (validpacket) {
> // snip
> } else {
> LOG.warn("Dropping packet at server of type " + si.type);
> // if invalid packet drop the packet.
> }
> } catch (MissingSessionException e) {
> if (LOG.isDebugEnabled()) {
> LOG.debug("Dropping request: " + e.getMessage());
> }
> }
> }
> {noformat}
> The solution discussed in ZOOKEEPER-1381 would be to get an exception on the
> client side then & close the session.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
