[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562338#comment-13562338
 ] 

Edward Ribeiro commented on ZOOKEEPER-1346:
-------------------------------------------

Hi, 

It just occurred me that there are some classes that the current version of 
this patch doesn't contemplate: 

/src/java/main/org/apache/zookeeper/client/FourLetterWordMain.java
/src/java/test/org/apache/zookeeper/test/FourLetterWordsQuorumTest.java
/src/java/test/org/apache/zookeeper/test/FourLetterWordsTest.java

It would be nice to take a look at least on the first one. Did you already have 
anything planned to them? I really don't know if it's better to include it in 
another version of your patch, create a separate patch to address them, or just 
deprecate them all. What do you think? Or I misunderstood something.

PS: The FourLetterWordMain rewrite seems just a matter of making a 
URLConnection and read the input, no big deal really.

Cheers,
E.



                
> Handle 4lws and monitoring on separate port
> -------------------------------------------
>
>                 Key: ZOOKEEPER-1346
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1346
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>            Reporter: Camille Fournier
>            Assignee: Skye Wanderman-Milne
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1346.2.patch, ZOOKEEPER-1346.3.patch, 
> ZOOKEEPER-1346.4.patch, ZOOKEEPER-1346.6.patch, ZOOKEEPER-1346.7.patch, 
> ZOOKEEPER-1346.8.patch, ZOOKEEPER-1346_jetty.patch, ZOOKEEPER-1346.patch
>
>
> Move the 4lws to their own port, off of the client port, and support them 
> properly via long-lived sessions instead of polling. Deprecate the 4lw 
> support on the client port. Will enable us to enhance the functionality of 
> the commands via extended command syntax, address security concerns and fix 
> bugs involving the socket close being received before all of the data on the 
> client end.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to