[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13579810#comment-13579810
 ] 

Arnoud Glimmerveen commented on ZOOKEEPER-1645:
-----------------------------------------------

Great that the patch is applied, but while reviewing the changes myself I 
realized something: the build.xml creates two jar files. The attached patch 
only fixed the headers for the jar created in the *jar* target and not the one 
in *bin-jar*. Not sure if I understand the build.xml correctly, but it appears 
the latter is to be uploaded to maven. In any case, the headers should be 
consistent in both jar files.
I think the patch provided for ZOOKEEPER-1334 may have the same issue!

Should I create a new issue for this?
                
> ZooKeeper OSGi package imports not complete
> -------------------------------------------
>
>                 Key: ZOOKEEPER-1645
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1645
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.5.0, 3.4.6
>            Reporter: Arnoud Glimmerveen
>            Assignee: Arnoud Glimmerveen
>             Fix For: 3.5.0, 3.4.6
>
>         Attachments: ZOOKEEPER-1645.patch
>
>
> The ZooKeeper bundle relies on three packages it currently does not declare 
> in the Import-Package MANIFEST header: {{javax.security.auth.callback}} , 
> {{javax.security.auth.login}} and {{javax.security.sasl}} . By adding these 
> the ZooKeeper jar will be a valid OSGi bundle.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to