[
https://issues.apache.org/jira/browse/ZOOKEEPER-1640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tian Hong Wang updated ZOOKEEPER-1640:
--------------------------------------
Description:
In class org.apache.zookeeper.ZooKeeperMain.java,
new CloseCommand().addToMap(commandMapCli);
new CreateCommand().addToMap(commandMapCli);
new DeleteCommand().addToMap(commandMapCli);
new DeleteAllCommand().addToMap(commandMapCli);
// Depricated: rmr
new DeleteAllCommand("rmr").addToMap(commandMapCli);
new SetCommand().addToMap(commandMapCli);
new GetCommand().addToMap(commandMapCli);
new LsCommand().addToMap(commandMapCli);
new Ls2Command().addToMap(commandMapCli);
new GetAclCommand().addToMap(commandMapCli);
new SetAclCommand().addToMap(commandMapCli);
new StatCommand().addToMap(commandMapCli);
new SyncCommand().addToMap(commandMapCli);
new SetQuotaCommand().addToMap(commandMapCli);
new ListQuotaCommand().addToMap(commandMapCli);
new DelQuotaCommand().addToMap(commandMapCli);
new AddAuthCommand().addToMap(commandMapCli);
The above code is not flexible for command object scalability. It's better to
refine the code to load and create the command objects dynamically.
was:
Class org.apache.zookeeper.ZooKeeperMain.java uses hard code to load command
objects in client site.
It need to dynamically load command objects in case of command extension.
> dynamically load command objects in zk
> --------------------------------------
>
> Key: ZOOKEEPER-1640
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1640
> Project: ZooKeeper
> Issue Type: Improvement
> Components: java client
> Reporter: Tian Hong Wang
> Assignee: Tian Hong Wang
> Labels: patch
> Fix For: 3.4.5
>
> Attachments: zookeeper.patch
>
>
> In class org.apache.zookeeper.ZooKeeperMain.java,
> new CloseCommand().addToMap(commandMapCli);
> new CreateCommand().addToMap(commandMapCli);
> new DeleteCommand().addToMap(commandMapCli);
> new DeleteAllCommand().addToMap(commandMapCli);
> // Depricated: rmr
> new DeleteAllCommand("rmr").addToMap(commandMapCli);
> new SetCommand().addToMap(commandMapCli);
> new GetCommand().addToMap(commandMapCli);
> new LsCommand().addToMap(commandMapCli);
> new Ls2Command().addToMap(commandMapCli);
> new GetAclCommand().addToMap(commandMapCli);
> new SetAclCommand().addToMap(commandMapCli);
> new StatCommand().addToMap(commandMapCli);
> new SyncCommand().addToMap(commandMapCli);
> new SetQuotaCommand().addToMap(commandMapCli);
> new ListQuotaCommand().addToMap(commandMapCli);
> new DelQuotaCommand().addToMap(commandMapCli);
> new AddAuthCommand().addToMap(commandMapCli);
> The above code is not flexible for command object scalability. It's better to
> refine the code to load and create the command objects dynamically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
