[
https://issues.apache.org/jira/browse/ZOOKEEPER-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13597787#comment-13597787
]
Hadoop QA commented on ZOOKEEPER-1662:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12572871/TestPortChange.patch
against trunk revision 1453693.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1426//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1426//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1426//console
This message is automatically generated.
> Fix to two small bugs in ReconfigTest.testPortChange()
> ------------------------------------------------------
>
> Key: ZOOKEEPER-1662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1662
> Project: ZooKeeper
> Issue Type: Bug
> Components: tests
> Affects Versions: 3.5.0
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: TestPortChange.patch
>
>
> Fix to two small bugs in ReconfigTest.testPortChange():
> 1. the test expected a port change to happen immediately, which is not
> necessarily
> going to happen. The fix waits a bit and also tries several times.
> 2. when a client port changes, the test created a new ZooKeeper handle, but
> didn't specify a Watcher object, which generated some NullPointerException
> events when the watcher was triggered.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
