[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13606829#comment-13606829
 ] 

Enis Soztutar commented on ZOOKEEPER-1670:
------------------------------------------

The patch looks good, but I am wondering whether it makes sense to add a 
default conf/zookeeper-env.sh, and add the default there. bin/zkEnv.sh roughly 
corresponds to bin/hadoop-config.sh, and conf/zookeeper-env.sh roughly 
corresponds to conf/hadoop-env.sh from my understanding. 
                
> zookeeper should set a default value for SERVER_JVMFLAGS so that memory usage 
> is controlled
> -------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1670
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1670
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.4.5
>            Reporter: Arpit Gupta
>            Assignee: Arpit Gupta
>             Fix For: 3.4.6
>
>         Attachments: ZOOKEEPER-1670.patch
>
>
> We noticed this with jdk 1.6 where if no heap size is set the process takes 
> up to 1/4 of mem available on the machine.
> More info 
> http://stackoverflow.com/questions/3428251/is-there-a-default-xmx-setting-for-java-1-5
> You can run the following command to see what are the defaults for your 
> machine
> {code}
> java -XX:+PrintFlagsFinal -version 2>&1 | grep -i -E 
> 'heapsize|permsize|version'
> {code}
> And we noticed on two different class of machines that this was 1/4th of 
> total memory on the machine.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to