[ https://issues.apache.org/jira/browse/ZOOKEEPER-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625926#comment-13625926 ]
Hadoop QA commented on ZOOKEEPER-1670: -------------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12577635/ZOOKEEPER-1670.patch against trunk revision 1463329. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1449//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1449//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1449//console This message is automatically generated. > zookeeper should set a default value for SERVER_JVMFLAGS and CLIENT_JVMFLAGS > so that memory usage is controlled > --------------------------------------------------------------------------------------------------------------- > > Key: ZOOKEEPER-1670 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1670 > Project: ZooKeeper > Issue Type: Bug > Affects Versions: 3.4.5 > Reporter: Arpit Gupta > Assignee: Arpit Gupta > Fix For: 3.4.6 > > Attachments: ZOOKEEPER-1670.patch, ZOOKEEPER-1670.patch, > ZOOKEEPER-1670.patch, ZOOKEEPER-1670.patch > > > We noticed this with jdk 1.6 where if no heap size is set the process takes > up to 1/4 of mem available on the machine. > More info > http://stackoverflow.com/questions/3428251/is-there-a-default-xmx-setting-for-java-1-5 > You can run the following command to see what are the defaults for your > machine > {code} > java -XX:+PrintFlagsFinal -version 2>&1 | grep -i -E > 'heapsize|permsize|version' > {code} > And we noticed on two different class of machines that this was 1/4th of > total memory on the machine. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira