[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649707#comment-13649707
 ] 

Flavio Junqueira commented on ZOOKEEPER-1551:
---------------------------------------------

I have generated a new version of this patch that applies to trunk. The 
previous patch that [~thawan] generated has also been affected by the 
ZOOKEEPER-107 changes. 

This patch depends on ZOOKEEPER-1552 and I verified that the patch there 
applies to trunk. 

Now I'm a bit confused about the fix versions of these issues. This one says 
3.4.6 and 3.5.0. ZOOKEEPER-1552 says 3.5.0. This comments from Thawan:

https://issues.apache.org/jira/browse/ZOOKEEPER-1551?focusedCommentId=13591262&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13591262

says that it might be for 3.4.6 only. To me it sounds like it should be in 
3.5.0, since ZOOKEEPER-1552 is an improvement, having it in 3.4.6 is optional. 
Any opinion here?
                
> Observer ignore txns that comes after snapshot and UPTODATE 
> ------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1551
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1551
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: quorum, server
>    Affects Versions: 3.4.3
>            Reporter: Thawan Kooburat
>            Assignee: Thawan Kooburat
>            Priority: Blocker
>             Fix For: 3.5.0, 3.4.6
>
>         Attachments: ZOOKEEPER-1551.patch, ZOOKEEPER-1551.patch, 
> ZOOKEEPER-1551-trunk.patch
>
>
> In Learner.java, txns which comes after the learner has taken the snapshot 
> (after NEWLEADER packet) are stored in packetsNotCommitted. The follower has 
> special logic to apply these txns at the end of syncWithLeader() method. 
> However, the observer will ignore these txns completely, causing data 
> inconsistency. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to