[
https://issues.apache.org/jira/browse/BOOKKEEPER-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13677225#comment-13677225
]
Hadoop QA commented on BOOKKEEPER-618:
--------------------------------------
Testing JIRA BOOKKEEPER-618
Patch
[0001-BOOKKEEPER-618-Better-resolution-of-bookie-address.patch|https://issues.apache.org/jira/secure/attachment/12586523/0001-BOOKKEEPER-618-Better-resolution-of-bookie-address.patch]
downloaded at Thu Jun 6 16:31:02 UTC 2013
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
120
. {color:green}+1{color} the patch does adds/modifies 7 testcase(s)
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
{color:green}+1 TESTS{color}
. Tests run: 842
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:green}*+1 Overall result, good!, no -1s*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/352/
> Better resolution of bookie address
> -----------------------------------
>
> Key: BOOKKEEPER-618
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-618
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Affects Versions: 4.2.1
> Reporter: Bryan Beaudreault
> Assignee: Ivan Kelly
> Priority: Minor
> Fix For: 4.3.0, 4.2.2
>
> Attachments:
> 0001-BOOKKEEPER-618-Better-resolution-of-bookie-address.patch
>
>
> Bookie#getBookieAddress uses the following code:
> {code:title=Bookie.java}
> /**
> * Return the configured address of the bookie.
> */
> public static InetSocketAddress getBookieAddress(ServerConfiguration conf)
> throws UnknownHostException {
> return new InetSocketAddress(InetAddress.getLocalHost()
> .getHostAddress(), conf.getBookiePort());
> }
> {code}
> This code is subject to the contents of one's /etc/hosts file, in that if
> they have an entry like {{127.0.0.1 myhostname}}, this method will return the
> same 127.0.0.1 address on all bookie servers. This causes conflicts due to
> the way bookies register in zookeeper.
> There should be an optional bk_server.conf setting to allow one to select
> their preferred network interface to use for the bookie. Then you could use
> something like
> {{NetworkInterface.getByName(PREFERRED_INTERFACE).getInetAddresses()}}
> instead. This method is not effected by the /etc/hosts.
> An alternative method of registering the bookie that does not rely on the
> local address would be another possible solution, such as using the DNS like
> other apache projects (hbase).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
