[
https://issues.apache.org/jira/browse/ZOOKEEPER-1730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13715958#comment-13715958
]
Thawan Kooburat commented on ZOOKEEPER-1730:
--------------------------------------------
Comments:
1. instead of using debugSendThreadExitLatch. You should be able to just call
clientCnxn.sendThread.join() to wait for sendThread to exit inside
injectSessionExpiration()
2. Can you rename TestTestable to be something like ZooKeeperTestableTest.
This seem to be a naming conversion for the rest of the test cases
3. in unit test, it will be great if we you can also check that we get
disconnected and then followed by session expired event.
The rest looks good to me.
> Make ZooKeeper easier to test - support simulating a session expiration
> -----------------------------------------------------------------------
>
> Key: ZOOKEEPER-1730
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1730
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: java client
> Reporter: Jordan Zimmerman
> Assignee: Jordan Zimmerman
> Fix For: 3.5.0
>
> Attachments: gitdiff, ZOOKEEPER-1730-2.patch, ZOOKEEPER-1730-3.patch
>
>
> As part of making ZooKeeper clients more test friendly, it would be useful to
> easily simulate a session loss event
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
