[
https://issues.apache.org/jira/browse/ZOOKEEPER-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13742193#comment-13742193
]
Hadoop QA commented on ZOOKEEPER-1741:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12598448/zk-symlinked-scripts.patch
against trunk revision 1503101.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 patch. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1541//console
This message is automatically generated.
> bin scripts don't dereference symlinks
> --------------------------------------
>
> Key: ZOOKEEPER-1741
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1741
> Project: ZooKeeper
> Issue Type: Bug
> Components: scripts
> Affects Versions: 3.4.5
> Environment: Centos 5.8
> Reporter: Max Lapan
> Priority: Trivial
> Attachments: zk-symlinked-scripts.patch
>
>
> Symlinks on bin scripts are not dereferenced correctly ("set -x" added):
> {noformat}
> [root@tsthdp1 noarch]# which zookeeper-client
> /usr/local/bin/zookeeper-client
> [root@tsthdp1 noarch]# ls -la /usr/local/bin/zookeeper-client
> lrwxrwxrwx 1 root root 40 Авг 16 15:56 /usr/local/bin/zookeeper-client ->
> /usr/local/hadoop/zookeeper/bin/zkCli.sh
> [root@tsthdp1 noarch]# ls -la /usr/local/hadoop/zookeeper/bin
> итого 36
> drwxr-xr-x 2 root root 4096 Авг 16 16:24 .
> drwxr-xr-x 5 root root 4096 Авг 16 15:56 ..
> -rwxr-xr-x 1 root root 1909 Авг 16 15:56 zkCleanup.sh
> -rwxr-xr-x 1 root root 1536 Авг 16 16:22 zkCli.sh
> -rwxr-xr-x 1 root root 2599 Авг 16 15:56 zkEnv.sh
> -rwxr-xr-x 1 root root 4559 Авг 16 15:56 zkServer-initialize.sh
> -rwxr-xr-x 1 root root 6246 Авг 16 15:56 zkServer.sh
> [root@tsthdp1 noarch]# zookeeper-client
> + ZOOBIN=/usr/local/bin/zookeeper-client
> ++ dirname /usr/local/bin/zookeeper-client
> + ZOOBIN=/usr/local/bin
> ++ cd /usr/local/bin
> ++ pwd
> + ZOOBINDIR=/usr/local/bin
> + '[' -e /usr/local/bin/../libexec/zkEnv.sh ']'
> + . /usr/local/bin/zkEnv.sh
> /usr/local/bin/zookeeper-client: line 37: /usr/local/bin/zkEnv.sh: no such
> file or directory
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
