[
https://issues.apache.org/jira/browse/ZOOKEEPER-1751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13755332#comment-13755332
]
Hadoop QA commented on ZOOKEEPER-1751:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12600907/zookeeper-1751.patch
against trunk revision 1516126.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1549//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1549//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1549//console
This message is automatically generated.
> ClientCnxn#run could miss the second ping or connection get dropped before a
> ping
> ---------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1751
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1751
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.4.5
> Reporter: Jeffrey Zhong
> Assignee: Jeffrey Zhong
> Attachments: zookeeper-1751.patch
>
>
> We could throw SessionTimeoutException exception even when timeToNextPing may
> also be negative depending on the time when the following line is executed by
> the thread because we check time out before sending a ping.
> {code}
> to = readTimeout - clientCnxnSocket.getIdleRecv();
> {code}
> In addition, we only ping twice no matter how long the session time out value
> is. For example, we set session time out = 60mins then we only try ping twice
> in 40mins window. Therefore, the connection could be dropped by OS after idle
> time out.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
