[
https://issues.apache.org/jira/browse/ZOOKEEPER-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13759161#comment-13759161
]
Hadoop QA commented on ZOOKEEPER-1753:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12601618/0001-ZOOKEEPER-1753-fix-branch-3_4.patch
against trunk revision 1519655.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1555//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1555//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1555//console
This message is automatically generated.
> ClientCnxn is not properly releasing the resources, which are used to ping
> RwServer
> -----------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1753
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1753
> Project: ZooKeeper
> Issue Type: Bug
> Components: java client
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 4.0.0, 3.4.6
>
> Attachments: 0001-ZOOKEEPER-1753-fix-branch-3_4.patch,
> 0001-ZOOKEEPER-1753.patch
>
>
> While pinging to the RwServer, ClientCnxn is opening a socket and using
> BufferedReader. These are not properly closed in finally block and could
> cause leaks on exceptional cases.
> ClientCnxn#pingRwServer()
> {code}
> try {
> Socket sock = new Socket(addr.getHostName(), addr.getPort());
> BufferedReader br = new BufferedReader(
> new InputStreamReader(sock.getInputStream()));
> ......
> sock.close();
> br.close();
> } catch (ConnectException e) {
> // ignore, this just means server is not up
> } catch (IOException e) {
> // some unexpected error, warn about it
> LOG.warn("Exception while seeking for r/w server " +
> e.getMessage(), e);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
