[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767297#comment-13767297
 ] 

Thawan Kooburat commented on ZOOKEEPER-1757:
--------------------------------------------

Reducing the severity because it is unlikely the server will load the snapshot 
cleanly.  It would fail other sanity check while deserializing the snapshot.

However, one thing to note is that we are using just 8-byte Aler32 checksum for 
the entire snapshot.  For snapshot, i think it would be better to go with 
md5sum.  In our internal branch, we compress the snapshot before writing, so we 
get additional checksum through compression   
                
> Adler32 may not be sufficient to protect against data corruption
> ----------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1757
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1757
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>         Environment: Linux.  Oracle JDK6/7
>            Reporter: Thawan Kooburat
>            Priority: Minor
>         Attachments: ZOOKEEPER.1757.patch, ZOOKEEPER.1757.patch
>
>
> I was investigating data inconsistency bug in our internal branch. One 
> possible area is snapshot/txnlog corruption. So I wrote a more robust 
> corruption test and found that it is easy to break our checksum algorithm 
> which is Adler32.
> When this happen, it is more likely that corrupted data will fail other 
> sanity check during deserialization phase, but it is still scary that it can 
> pass the checksum.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to