[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13769584#comment-13769584
 ] 

Germán Blanco commented on ZOOKEEPER-1096:
------------------------------------------

Manual steps to verify the patch:
- Documentation generated with two new parameters in "Unsafe options" list.
- Server started with fleListenOnAllIPs set to true, the server listens on all 
IPs.
- Server started with fleListenOnAllIPs not set or set to false, the server 
listens only on one IP.
- Leader started with zabListenOnAllIPs set to true, it listens on all IPs.
- Leader started with zabListenOnAllIPs not set or set to false, it listens 
only on one IP.
The log shows address "0.0.0.0:XXXX" when listening on all IPs and the specific 
IP address when it is listening just on one.
                
> Leader communication should listen on specified IP, not wildcard address
> ------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1096
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1096
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.3.3, 3.4.0
>            Reporter: Jared Cantwell
>            Assignee: Jared Cantwell
>            Priority: Minor
>             Fix For: 3.5.0, 3.4.6
>
>         Attachments: ZOOKEEPER-1096_branch3.4.patch, 
> ZOOKEEPER-1096_branch3.4.patch, ZOOKEEPER-1096.patch, ZOOKEEPER-1096.patch, 
> ZOOKEEPER-1096.patch, ZOOKEEPER-1096.patch
>
>
> Server should specify the local address that is used for leader communication 
> and leader election (and not use the default of listening on all interfaces). 
>  This is similar to the clientPortAddress parameter that was added a year 
> ago.  After reviewing the code, we can't think of a reason why only the port 
> would be used with the wildcard interface, when servers are already 
> connecting specifically to that interface anyway.
> I have submitted a patch, but it does not account for all leader election 
> algorithms.
> Probably should have an option to toggle this, for backwards compatibility, 
> although it seems like it would be a bug if this change broke things.
> There is some more information about making it an option here:
> http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/201008.mbox/%[email protected]%3E

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to