[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13773114#comment-13773114
 ] 

Hadoop QA commented on ZOOKEEPER-1388:
--------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12604248/0001-ZOOKEEPER-1388-trunk-version.patch
  against trunk revision 1524398.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1593//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1593//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1593//console

This message is automatically generated.
                
> Client side 'PathValidation' is missing for the multi-transaction api.
> ----------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1388
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1388
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: java client
>    Affects Versions: 3.4.0
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>            Priority: Minor
>             Fix For: 3.5.0
>
>         Attachments: 0001-ZOOKEEPER-1388-trunk-version.patch
>
>
> Multi ops: Op.create(path,..), Op.delete(path, ..), Op.setData(path, ..), 
> Op.check(path, ...) apis are not performing the client side path validation 
> and the call will go to the server side and is throwing exception back to the 
> client. 
> It would be good to provide ZooKeeper client side path validation for the 
> multi transaction apis. Presently its getting err codes from the server, 
> which is also not properly conveying the cause.
> For example: When specified invalid znode path in Op.create, it giving the 
> following exception. This will not be useful to know the actual cause.
> {code}
> org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = NoNode
>       at org.apache.zookeeper.KeeperException.create(KeeperException.java:115)
>       at org.apache.zookeeper.ZooKeeper.multiInternal(ZooKeeper.java:1174)
>       at org.apache.zookeeper.ZooKeeper.multi(ZooKeeper.java:1115)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to