[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13773690#comment-13773690
 ] 

Thawan Kooburat commented on ZOOKEEPER-1552:
--------------------------------------------

Is it possible that we also keep the JVM flag? 

All of the patch from our internal branch have a coding convention of 
introducing a JVM flag into a file that it affect the functionality. I can 
debate why it has some merit but I do agree that configuration file is easier 
to use for user. If this coding convention is not accept by upstream, I will 
have to change our internal coding convention as well because all 
pending/future patch has this style. 


                
> Enable sync request processor in Observer
> -----------------------------------------
>
>                 Key: ZOOKEEPER-1552
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1552
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: quorum, server
>    Affects Versions: 3.4.3
>            Reporter: Thawan Kooburat
>            Assignee: Flavio Junqueira
>             Fix For: 3.5.0, 3.4.6
>
>         Attachments: ZOOKEEPER-1552-3.4.patch, ZOOKEEPER-1552-b3.4.patch, 
> ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, 
> ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch
>
>
> Observer doesn't forward its txns to SyncRequestProcessor. So it never 
> persists the txns onto disk or periodically creates snapshots. This increases 
> the start-up time since it will get the entire snapshot if the observer has 
> be running for a long time. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to