[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13775869#comment-13775869
 ] 

Hadoop QA commented on ZOOKEEPER-1763:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12604575/1763.v1.patch
  against trunk revision 1524398.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1598//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1598//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1598//console

This message is automatically generated.
                
> Upgrade the netty version
> -------------------------
>
>                 Key: ZOOKEEPER-1763
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1763
>             Project: ZooKeeper
>          Issue Type: Improvement
>    Affects Versions: 3.4.5
>            Reporter: Nicolas Liochon
>            Assignee: Nicolas Liochon
>            Priority: Minor
>             Fix For: 3.5.0
>
>         Attachments: 1763.v1.patch
>
>
> 2 years ago (in https://github.com/netty/netty/issues/103), Netty changed 
> their group-id from org.jboss.netty to io.netty. ZooKeeper is still on the 
> 3.2.5, so applications using 3.3 cannot use the maven "dependencyManagement" 
> feature, as the group id differ. HBase & Hadoop 2 are on the branch 3.3+, 
> with the new group id.
> Note that the netty 4 changes the package name as well. That's not the case 
> for Netty 3.3+.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to