[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michi Mutsuzaki updated ZOOKEEPER-1766:
---------------------------------------

    Fix Version/s: 3.5.0

> Consistent log severity level guards and statements
> ---------------------------------------------------
>
>                 Key: ZOOKEEPER-1766
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1766
>             Project: ZooKeeper
>          Issue Type: Improvement
>    Affects Versions: 3.4.5
>            Reporter: Jackie Chang
>            Priority: Minor
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1766.patch
>
>
> A log statement should be guarded by its matching severity level. A log 
> statement like
>          if (LOG.isTraceEnabled()) {
>             LOG.info("Session closing: 0x" + Long.toHexString(sessionId));
> doesn't make much sense because the log message is only printed out when 
> TRACE-level is enabled. This inconsistency was possibly introduced when 
> developers demoted the original log statement from INFO but forgot to change 
> its corresponding log severity level.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to