[
https://issues.apache.org/jira/browse/ZOOKEEPER-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13787903#comment-13787903
]
Hadoop QA commented on ZOOKEEPER-1638:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12607124/ZOOKEEPER-1638.patch
against trunk revision 1529344.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1645//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1645//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1645//console
This message is automatically generated.
> Redundant zk.getZKDatabase().clear();
> -------------------------------------
>
> Key: ZOOKEEPER-1638
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1638
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Alexander Shraer
> Assignee: neil bhakta
> Priority: Trivial
> Labels: newbie
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1638.patch
>
>
> Learner.syncWithLeader calls zk.getZKDatabase().clear() right before
> zk.getZKDatabase().deserializeSnapshot(leaderIs); Then the first thing
> deserializeSnapshot does is another clear().
> Suggest to remove the clear() in syncWithLeader.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
