[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793333#comment-13793333
 ] 

Hudson commented on ZOOKEEPER-1610:
-----------------------------------

SUCCESS: Integrated in ZooKeeper-trunk #2087 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/2087/])
ZOOKEEPER-1610. Some classes are using == or != to compare Long/String objects 
instead of .equals() (Edward Ribeiro via phunt) (phunt: 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1531396)
* /zookeeper/trunk/CHANGES.txt
* 
/zookeeper/trunk/src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java
* 
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumHierarchical.java


> Some classes are using == or != to compare Long/String objects instead of 
> .equals()
> -----------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1610
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1610
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: java client, quorum
>    Affects Versions: 3.4.5, 3.5.0
>            Reporter: Edward Ribeiro
>            Assignee: Edward Ribeiro
>            Priority: Critical
>             Fix For: 3.4.6, 3.5.0
>
>         Attachments: ZOOKEEPER-1610-br34.patch, ZOOKEEPER-1610.patch
>
>
> The classes org.apache.zookeeper.client.ZooKeeperSaslClient.java and 
> org.apache.zookeeper.server.quorum.flexible.QuorumHierarchical.java compare 
> Strings and/or Longs using referential equality.
> Usually, this is not a problem because the Longs are cached and Strings are 
> interned, but I myself  had problems with those kind of comparisons in the 
> past because one production JVM didn't reused the objects.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to