[
https://issues.apache.org/jira/browse/ZOOKEEPER-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13803587#comment-13803587
]
Flavio Junqueira commented on ZOOKEEPER-1798:
---------------------------------------------
The fix you propose is good for me, +1. About the system exit call, I'm not
sure it is strictly necessary to have it there, although in some other part of
the class we do something similar. In the case we keep it, we might want to add
one of those findbugs exceptions.
> testNormalObserverRun failed on branch 3.4
> ------------------------------------------
>
> Key: ZOOKEEPER-1798
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1798
> Project: ZooKeeper
> Issue Type: Bug
> Reporter: Flavio Junqueira
> Assignee: Thawan Kooburat
> Priority: Blocker
> Fix For: 3.4.6, 3.5.0
>
> Attachments: TEST-org.apache.zookeeper.server.quorum.Zab1_0Test.txt,
> ZOOKEEPER-1798-b3.4.patch, ZOOKEEPER-1798-b3.4.patch, ZOOKEEPER-1798.patch
>
>
> This is the output messges:
> <noformat>
> Testcase: testNormalObserverRun took 4.221 sec
> FAILED
> expected:<data[2]> but was:<data[1]>
> junit.framework.AssertionFailedError: expected:<data[2]> but was:<data[1]>
> at
> org.apache.zookeeper.server.quorum.Zab1_0Test$8.converseWithObserver(Zab1_0Test.java:1118)
> at
> org.apache.zookeeper.server.quorum.Zab1_0Test.testObserverConversation(Zab1_0Test.java:546)
> at
> org.apache.zookeeper.server.quorum.Zab1_0Test.testNormalObserverRun(Zab1_0Test.java:994)
> <noformat>
--
This message was sent by Atlassian JIRA
(v6.1#6144)
