[ https://issues.apache.org/jira/browse/ZOOKEEPER-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13805530#comment-13805530 ]
David Lao commented on ZOOKEEPER-1459: -------------------------------------- Bear with me a bit since I'm new to the code base.. but I don't see ServerCnxnFactory closing the transaction log anywhere. My understanding is that ServerCnxnFactory deals only with socket connectivities. To your second point I agree the log closing is better done outside the server in runFromConfig. I've verified the patch works on by Windows box. > Standalone ZooKeeperServer is not closing the transaction log files on > shutdown > ------------------------------------------------------------------------------- > > Key: ZOOKEEPER-1459 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1459 > Project: ZooKeeper > Issue Type: Bug > Components: server > Affects Versions: 3.4.0 > Reporter: Rakesh R > Assignee: Rakesh R > Fix For: 3.4.6, 3.5.0 > > Attachments: ZOOKEEPER-1459.patch, ZOOKEEPER-1459.patch, > ZOOKEEPER-1459.patch, ZOOKEEPER-1459.patch, ZOOKEEPER-1459.patch, > ZOOKEEPER-1459.patch, ZOOKEEPER-1459.patch > > > When shutdown the standalone ZK server, its only clearing the zkdatabase and > not closing the transaction log streams. When tries to delete the temporary > files in unit tests on windows, its failing. > ZooKeeperServer.java > {noformat} > if (zkDb != null) { > zkDb.clear(); > } > {noformat} > Suggestion to close the zkDb as follows, this inturn will take care > transaction logs: > {noformat} > if (zkDb != null) { > zkDb.clear(); > try { > zkDb.close(); > } catch (IOException ie) { > LOG.warn("Error closing logs ", ie); > } > } > {noformat} -- This message was sent by Atlassian JIRA (v6.1#6144)