[
https://issues.apache.org/jira/browse/BOOKKEEPER-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13808197#comment-13808197
]
Sijie Guo commented on BOOKKEEPER-696:
--------------------------------------
> When we spoke in August, Aniruddha said this was to avoid metrics being taken
> which are hard to track down. This can be better achieved by scoping all
> metrics by the class they're measured in.
using enum is to have a central place to manage all the metrics that are being
exposed. but your patch is to put the metric implied by its class name. it
still lacks the convenience to track metrics in one place, as you have no idea
whether the class is exposing metrics or not. and in your patch, if the class
name is changed, its corresponding metric name is changed, which is really bad.
we should have fixed metric name regardless code refactoring.
+1 for builder idea, but I would suggest putting it in a separated task.
> stats collection on bookkeeper client
> -------------------------------------
>
> Key: BOOKKEEPER-696
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-696
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-client
> Reporter: Sijie Guo
> Assignee: Aniruddha
> Fix For: 4.3.0
>
> Attachments: 0001-client-stats-for-bookkeeper.patch
>
>
> Stats for bookkeeper client.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
