[
https://issues.apache.org/jira/browse/ZOOKEEPER-1790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13812078#comment-13812078
]
Alexander Shraer commented on ZOOKEEPER-1790:
---------------------------------------------
The problem described in this JIRA turned out not be a problem as I mention in
the first comment.
[~thawan], I'm actually not sure if -1 would work or not - there aren't any
tests for this in 3.4 or 3.5. I can't think of anything specific
that changed that would prevent it from working, but I may be wrong. As you
pointed out you wouldn't be able to dynamically change
the parameters of such observers.
> Deal with special ObserverId in QuorumCnxManager.receiveConnection
> ------------------------------------------------------------------
>
> Key: ZOOKEEPER-1790
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1790
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.4.6, 3.5.0
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.4.6, 3.5.0
>
>
> QuorumCnxManager.receiveConnection assumes that a negative sid means that
> this is a 3.5.0 server, which has a different communication protocol. This
> doesn't account for the fact that ObserverId = -1 is a special id that may be
> used by observers and is also negative.
> This requires a fix to trunk and a separate fix to 3.4 branch, where this
> function is different (see ZOOKEEPER-1633)
--
This message was sent by Atlassian JIRA
(v6.1#6144)
