[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13818228#comment-13818228
 ] 

Flavio Junqueira commented on ZOOKEEPER-1666:
---------------------------------------------

lgtm, I just have a couple of formatting comments:

# Lines look very long, could you break them up before committing?
# One of the closing curly braces is misaligned




> Avoid Reverse DNS lookup if the hostname in connection string is literal IP 
> address.
> ------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1666
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1666
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: java client
>            Reporter: George Cao
>            Assignee: George Cao
>              Labels: patch, test
>         Attachments: ZOOKEEPER-1666-34.patch, ZOOKEEPER-1666-34v2.patch, 
> ZOOKEEPER-1666.patch, ZOOKEEPER-1666.patch
>
>
> In our ENV, if the InetSocketAddress.getHostName() is called and the host 
> name in the connection string are literal IP address, then the call will 
> trigger a reverse DNS lookup which is very slow.
> And in this situation, the host name can simply set as the IP without causing 
> any problem. 



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to