[
https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13818397#comment-13818397
]
Germán Blanco commented on ZOOKEEPER-1808:
------------------------------------------
Unless you change this "if(response.buffer.capacity() == 40) {" to
"if(response.buffer.capacity() >= 40) {", it will not be easy to increase the
size of the message in the future. That means that the version field will have
very limited (if any) use, since changing the first 36 bytes of the message
breaks backwards compatibility with 3.4.5.
> Add version to FLE notifications for 3.4 branch
> -----------------------------------------------
>
> Key: ZOOKEEPER-1808
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Fix For: 3.4.6
>
> Attachments: ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch,
> ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch
>
>
> Add version to notification messages so that we can differentiate messages
> during rolling upgrades. This task is for the 3.4 branch only.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
