[
https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823731#comment-13823731
]
Raul Gutierrez Segales commented on ZOOKEEPER-1808:
---------------------------------------------------
Some more nits:
In
src/java/test/org/apache/zookeeper/server/quorum/FLEBackwardElectionRoundTest.java#testBackwardElectionRound():
FLETestUtils.createMsg() again and again with the same params. Can we reuse for
clarity & perf?
In src/java/test/org/apache/zookeeper/server/quorum/FLECompatibilityTest.java:
{noformat}
+ for(int i = 0; i < count; i++) {
+ peers.put(Long.valueOf(i),
+ new QuorumServer(i,
+ new InetSocketAddress(PortAssignment.unique()),
+ new InetSocketAddress(PortAssignment.unique())));
+ tmpdir[i] = ClientBase.createTmpDir();
+ port[i] = PortAssignment.unique();
+ }
{noformat}
is repeated between tests. Can we make it a private method and call that to
keep the file shorter? Also leave a space after the for keyword (for (int ...)).
In:
{noformat}
+ ByteBuffer buffer = FastLeaderElection.buildMsg(
ServerState.LOOKING.ordinal(), 2, 0x1, 1, 1 );
{noformat}
no spaces between parentheses and parameters. Ditto about spaces in the call to
buildMsg in
src/java/test/org/apache/zookeeper/server/quorum/CnxManagerTest.java.
Besides those nits, +1. Thanks [~fpj].
> Add version to FLE notifications for 3.4 branch
> -----------------------------------------------
>
> Key: ZOOKEEPER-1808
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Fix For: 3.4.6
>
> Attachments: ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch,
> ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch,
> ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch
>
>
> Add version to notification messages so that we can differentiate messages
> during rolling upgrades. This task is for the 3.4 branch only.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
