[
https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825753#comment-13825753
]
Hadoop QA commented on ZOOKEEPER-1742:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12614460/ZOOKEEPER-1742.patch
against trunk revision 1542355.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 27 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1788//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1788//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1788//console
This message is automatically generated.
> "make check" doesn't work on macos
> ----------------------------------
>
> Key: ZOOKEEPER-1742
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.4.5, 3.5.0
> Reporter: Flavio Junqueira
> Assignee: Germán Blanco
> Fix For: 3.4.6, 3.5.0
>
> Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch,
> ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch,
> ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch,
> ZOOKEEPER-1742.patch
>
>
> There are two problems I have spotted when running "make check" with the C
> client. First, it complains that the sleep call is not defined in two test
> files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc.
> Including unistd.h works. The second problem is with linker options. It
> complains that "--wrap" is not a valid. I'm not sure how to deal with this
> one yet, since I'm not sure why we are using it.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
