----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15568/#review29152 -----------------------------------------------------------
./src/java/test/org/apache/zookeeper/server/quorum/FLEBackwardElectionRoundTest.java <https://reviews.apache.org/r/15568/#comment56285> LOG.info("TestLE: {}, {}", getTestName(), count); ./src/java/test/org/apache/zookeeper/server/quorum/FLEBackwardElectionRoundTest.java <https://reviews.apache.org/r/15568/#comment56287> nit: extra newline. ./src/java/test/org/apache/zookeeper/server/quorum/FLELostMessageTest.java <https://reviews.apache.org/r/15568/#comment56286> extra newline. ./src/java/test/org/apache/zookeeper/server/quorum/FLELostMessageTest.java <https://reviews.apache.org/r/15568/#comment56288> ditto with use of {} instead of concatenations. ./src/java/test/org/apache/zookeeper/server/quorum/FLELostMessageTest.java <https://reviews.apache.org/r/15568/#comment56289> nit: extra newline. ./src/java/test/org/apache/zookeeper/server/quorum/FLELostMessageTest.java <https://reviews.apache.org/r/15568/#comment56290> nit: extra newline. ./src/java/test/org/apache/zookeeper/server/quorum/FLETestUtils.java <https://reviews.apache.org/r/15568/#comment56291> nit: extra newline. ./src/java/test/org/apache/zookeeper/server/quorum/FLETestUtils.java <https://reviews.apache.org/r/15568/#comment56292> nit: LOG.info("Constructor: {}", getName()) and an extra newline. ./src/java/test/org/apache/zookeeper/server/quorum/FLETestUtils.java <https://reviews.apache.org/r/15568/#comment56293> nit: space between try and { ./src/java/test/org/apache/zookeeper/server/quorum/FLETestUtils.java <https://reviews.apache.org/r/15568/#comment56294> nit: use {} instead of +. ./src/java/test/org/apache/zookeeper/server/quorum/FLETestUtils.java <https://reviews.apache.org/r/15568/#comment56295> ditto ./src/java/test/org/apache/zookeeper/server/quorum/FLETestUtils.java <https://reviews.apache.org/r/15568/#comment56296> nit: extra newline. - Raul Gutierrez Segales On Nov. 18, 2013, 7:56 p.m., German Blanco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15568/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2013, 7:56 p.m.) > > > Review request for zookeeper, fpj and Raul Gutierrez Segales. > > > Bugs: ZOOKEEPER-1810 > https://issues.apache.org/jira/browse/ZOOKEEPER-1810 > > > Repository: zookeeper > > > Description > ------- > > See ZOOKEEPER-1810 > > > Diffs > ----- > > ./src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java > 1542171 > ./src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java > 1542171 > ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 1542171 > ./src/java/main/org/apache/zookeeper/server/quorum/Vote.java 1542171 > > ./src/java/test/org/apache/zookeeper/server/quorum/FLEBackwardElectionRoundTest.java > PRE-CREATION > ./src/java/test/org/apache/zookeeper/server/quorum/FLELostMessageTest.java > PRE-CREATION > ./src/java/test/org/apache/zookeeper/server/quorum/FLETestUtils.java > PRE-CREATION > ./src/java/test/org/apache/zookeeper/test/FLEBackwardElectionRoundTest.java > 1542171 > ./src/java/test/org/apache/zookeeper/test/FLELostMessageTest.java 1542171 > ./src/java/test/org/apache/zookeeper/test/FLENewEpochTest.java 1542171 > ./src/java/test/org/apache/zookeeper/test/FLEPredicateTest.java 1542171 > ./src/java/test/org/apache/zookeeper/test/FLETest.java 1542171 > ./src/java/test/org/apache/zookeeper/test/FLETestUtils.java 1542171 > ./src/java/test/org/apache/zookeeper/test/FLEZeroWeightTest.java 1542171 > ./src/java/test/org/apache/zookeeper/test/LENonTerminateTest.java 1542171 > > Diff: https://reviews.apache.org/r/15568/diff/ > > > Testing > ------- > > Test included. > > > Thanks, > > German Blanco > >
