[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829494#comment-13829494
 ] 

Daniel Knightly commented on ZOOKEEPER-1819:
--------------------------------------------

Index: src/java/test/org/apache/zookeeper/server/DeserializationPerfTest.java
===================================================================
--- src/java/test/org/apache/zookeeper/server/DeserializationPerfTest.java      
(revision 1544262)
+++ src/java/test/org/apache/zookeeper/server/DeserializationPerfTest.java      
(working copy)
@@ -40,7 +40,7 @@
         int count;
         {
             DataTree tree = new DataTree();
-            SerializationPerfTest.createNodes(tree, "/", depth, 
tree.getNode("/").stat.getCversion(), width, new byte[len]);
+            SerializationPerfTest.createNodes(tree, "/", depth, width, 
tree.getNode("/").stat.getCversion(), new byte[len]);
             count = tree.getNodeCount();

             ByteArrayOutputStream baos = new ByteArrayOutputStream();

> DeserializationPerfTest calls 
> ------------------------------
>
>                 Key: ZOOKEEPER-1819
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1819
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: tests
>    Affects Versions: 3.5.0
>            Reporter: Daniel Knightly
>            Priority: Minor
>             Fix For: 3.5.0
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The DeserializationPerfTest calls
> SerializationPerfTest.createNodes to create serialized nodes to deserialize.
> However 2 of the arguments, childcount and parentCVersion are switched in the 
> call to the above method.  This results in all tests unintentionally testing 
> the same scenario.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to