[
https://issues.apache.org/jira/browse/ZOOKEEPER-1834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13844797#comment-13844797
]
Michi Mutsuzaki commented on ZOOKEEPER-1834:
--------------------------------------------
The patch looks good to me except for 2 minor nits:
- Use spaces instead of tabs.
- In the block above, we set inputStream to null after closing it. Do we need
to do the same here?
> Catch IOException in FileTxnLog
> -------------------------------
>
> Key: ZOOKEEPER-1834
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1834
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Fix For: 3.4.6, 3.5.0
>
> Attachments: ZOOKEEPER-1834-b3.4.patch, ZOOKEEPER-1834.patch
>
>
> Upon an IOException in FileTxnLog#next(), the log file open remains open,
> which causes test cases at least in BufferSizeTest to fail. We need to add a
> catch block.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
