[
https://issues.apache.org/jira/browse/ZOOKEEPER-1834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flavio Junqueira updated ZOOKEEPER-1834:
----------------------------------------
Attachment: ZOOKEEPER-1834-b3.4.patch
ZOOKEEPER-1834.patch
Well spotted, I had my settings broken. Uploading new patch files.
About the null assignment, we need it in the previous catch block because we
call next again in the case we reach the end of the file. In the case of an
IOException, we are not calling next again.
> Catch IOException in FileTxnLog
> -------------------------------
>
> Key: ZOOKEEPER-1834
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1834
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Fix For: 3.4.6, 3.5.0
>
> Attachments: ZOOKEEPER-1834-b3.4.patch, ZOOKEEPER-1834-b3.4.patch,
> ZOOKEEPER-1834.patch, ZOOKEEPER-1834.patch
>
>
> Upon an IOException in FileTxnLog#next(), the log file open remains open,
> which causes test cases at least in BufferSizeTest to fail. We need to add a
> catch block.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
