[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13845759#comment-13845759
 ] 

Bruno Freudensprung commented on ZOOKEEPER-1691:
------------------------------------------------

Hi,
I've just tested the patch on the trunk and unfortunately I didn't succeed to 
perform an incremental reconfig (add 1 ZK node to a 2 ZK nodes cluster). 
I have to say I made the test on Windows 7 with Oracle JDK 1.6.0_32 64-bit, so 
I don't know if it is relevant.
Anyway you will find attached my test configuration and scenario. As I am a ZK 
beginner (still very interested in the dynamic reconfig feature), maybe I did 
something wrong.
During the process, I discovered the reconfig fails to rename the tmp dynamic 
config file to the real dynamic config filename (javadoc of 
java.io.File.renameTo says the behavior is highly plateform dependent, so I 
guess this should not be a big surprise since I did the test on Windows).
That's why my test scenario ran after I modified 
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java like 
this (after having applied the patch) :
+           curFile.delete();
            if (!tmpFile.renameTo(curFile)) {
+                   configFile.delete();
                    if (!tmpFile.renameTo(configFile)) {

I also discovered that, when clientPort=2183 and standaloneEnabled=false (this 
one makes the difference) are omitted from the zoo.cfg of my server 3 (see my 
test scenario), the server won't listen on the client port (tries to bind to 
port "null"):
2013-12-11 22:48:08,227 [myid:] - INFO  [main:NIOServerCnxnFactory@683] - 
binding to port null

Bruno.

> Add a flag to disable standalone mode
> -------------------------------------
>
>                 Key: ZOOKEEPER-1691
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1691
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: quorum
>            Reporter: Michi Mutsuzaki
>            Assignee: Helen Hastings
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1691.patch, ZOOKEEPER-1691.patch, 
> ZOOKEEPER-1691.patch, ZOOKEEPER-1691.patch, ZOOKEEPER-1691.patch, 
> ZOOKEEPER-1691.patch
>
>
> Currently you cannot use dynamic reconfiguration to bootstrap zookeeper 
> cluster because the server goes into standalone mode when there is only one 
> server in the cluster.
> --Michi



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Reply via email to