----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15753/#review30347 -----------------------------------------------------------
./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java <https://reviews.apache.org/r/15753/#comment58077> nit: extra newline ./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java <https://reviews.apache.org/r/15753/#comment58078> nit: extra newline ./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java <https://reviews.apache.org/r/15753/#comment58075> nit: close implies flush, see http://docs.oracle.com/javase/7/docs/api/java/io/OutputStreamWriter.html#close%28%29 ./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java <https://reviews.apache.org/r/15753/#comment58076> ditto, flush is not needed. ./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java <https://reviews.apache.org/r/15753/#comment58079> nit: extra newline ./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java <https://reviews.apache.org/r/15753/#comment58080> nit: extra newline ./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java <https://reviews.apache.org/r/15753/#comment58081> nit: extra newline ./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java <https://reviews.apache.org/r/15753/#comment58082> nit: extra newline ./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java <https://reviews.apache.org/r/15753/#comment58087> nit: i don't think the LOG statement needs a comment, you can probably drop it and it would still be clear. ./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java <https://reviews.apache.org/r/15753/#comment58084> nit: make these lines < 80 cols. ./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java <https://reviews.apache.org/r/15753/#comment58085> nit: make these lines < 80 cols. ./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java <https://reviews.apache.org/r/15753/#comment58083> nit: you can use String.format instead of concatenating strings. [1] http://docs.oracle.com/javase/7/docs/api/java/lang/String.html#format%28java.lang.String,%20java.lang.Object...%29 - Raul Gutierrez Segales On Dec. 13, 2013, 9:13 a.m., Daniel Peon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15753/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2013, 9:13 a.m.) > > > Review request for zookeeper, German Blanco and fpj. > > > Bugs: ZOOKEEPER-1814 > https://issues.apache.org/jira/browse/ZOOKEEPER-1814 > > > Repository: zookeeper > > > Description > ------- > > See Zookeeper-1814. > > > Diffs > ----- > > ./src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml 1550368 > ./src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java > 1550368 > ./src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java > 1550368 > > ./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/15753/diff/ > > > Testing > ------- > > New test case checking that the parameter maxNotificationInterval can be > configurable. > > The test case overwrites the receiveConnection method in QuorumCnxManager > class in order to avoid any answer to Fast Leader Election. Thus, FLE is > forced to retry increasing exponentially the notifications interval. This > interval is measured and the test case stops when 3 consecutive measures are > equal. The test case will be OK if the measure is the configured in the cfg > file. > > > File Attachments > ---------------- > > ZOOKEEPER-1814.patch > > https://reviews.apache.org/media/uploaded/files/2013/12/11/7e510364-6df3-486e-b338-3398960ba6b0__ZOOKEEPER-1814.patch > > > Thanks, > > Daniel Peon > >
