[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13868351#comment-13868351
 ] 

Raul Gutierrez Segales commented on ZOOKEEPER-442:
--------------------------------------------------

Ah, good catch [~fournc] - mind filing a bug for that?

Though it still feels weird that the callback would be call from within the 
async dispatcher method. A bit tangential but the C implementation does error 
out early when it can't dispatch async requests (as opposed to calling the 
callback), i.e.: 

https://github.com/apache/zookeeper/blob/trunk/src/c/src/zookeeper.c#L3063

I guess it is also true that this is the first async method that actually does 
some real client side validation before issuing the call? It will probably feel 
more natural for the caller to know right away that the call wasn't dispatched, 
as opposed to be informed through the callback.

But this is minor so if everyone else is happy it would be very nice to see 
this merged!

> need a way to remove watches that are no longer of interest
> -----------------------------------------------------------
>
>                 Key: ZOOKEEPER-442
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-442
>             Project: ZooKeeper
>          Issue Type: Sub-task
>          Components: java client, server
>            Reporter: Benjamin Reed
>            Assignee: Rakesh R
>            Priority: Critical
>             Fix For: 3.5.0
>
>         Attachments: Remove Watch API.pdf, ZOOKEEPER-442.patch, 
> ZOOKEEPER-442.patch, ZOOKEEPER-442.patch, ZOOKEEPER-442.patch, 
> ZOOKEEPER-442.patch, ZOOKEEPER-442.patch, ZOOKEEPER-442.patch, 
> ZOOKEEPER-442.patch, ZOOKEEPER-442.patch, ZOOKEEPER-442.patch, 
> ZOOKEEPER-442.patch
>
>
> currently the only way a watch cleared is to trigger it. we need a way to 
> enumerate the outstanding watch objects, find watch events the objects are 
> watching for, and remove interests in an event.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to