[
https://issues.apache.org/jira/browse/ZOOKEEPER-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13876190#comment-13876190
]
Hadoop QA commented on ZOOKEEPER-1864:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12623904/BackwardsCompatCheck.patch
against trunk revision 1558950.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1894//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1894//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1894//console
This message is automatically generated.
> quorumVerifier is null when creating a QuorumPeerConfig from parsing a
> Properties object
> ----------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1864
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1864
> Project: ZooKeeper
> Issue Type: Bug
> Reporter: some one
> Assignee: some one
> Fix For: 3.5.0
>
> Attachments: BackwardsCompatCheck.patch
>
>
> This bug was found when using ZK 3.5.0 with curator-test 2.3.0.
> curator-test is building a QuorumPeerConfig from a Properties object and then
> when we try to run the quorum peer using that configuration, we get an NPE:
> {noformat}
> 2014-01-19 21:58:39,768 [myid:] - ERROR
> [Thread-3:TestingZooKeeperServer$1@138] - From testing server (random state:
> false)
> java.lang.NullPointerException
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.setQuorumVerifier(QuorumPeer.java:1320)
> at
> org.apache.zookeeper.server.quorum.QuorumPeerMain.runFromConfig(QuorumPeerMain.java:156)
> at
> org.apache.curator.test.TestingZooKeeperServer$1.run(TestingZooKeeperServer.java:134)
> at java.lang.Thread.run(Thread.java:722)
> {noformat}
> The reason that this happens is because QuorumPeerConfig:parseProperties only
> peforms a subset of what 'QuorumPeerConfig:parse(String path)' does. The
> exact additional task performed that we need in parseProperties is the
> dynamic config backwards compatibility check:
> {noformat}
> // backward compatibility - dynamic configuration in the same
> file as static configuration params
> // see writeDynamicConfig() - we change the config file to new
> format if reconfig happens
> if (dynamicConfigFileStr == null) {
> configBackwardCompatibilityMode = true;
> configFileStr = path;................
> parseDynamicConfig(cfg, electionAlg, true);
> checkValidity();................
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
