[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13881645#comment-13881645
 ] 

Thawan Kooburat commented on ZOOKEEPER-1847:
--------------------------------------------

I would love to fix this as well. However, it is going to get reintroduce as 
new patch being accepted. 

It would be better to invest effort in enforcing this on a new patch which I 
don't know how to do that with the current workflow

> Normalize line endings in repository
> ------------------------------------
>
>                 Key: ZOOKEEPER-1847
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1847
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>             Fix For: 3.5.0
>
>         Attachments: zookeeper-1847_v1.patch
>
>
> It is good practice to have all the code in the repository use the same line 
> endings (LF) so that patches can be applied normally. We can add a 
> gitattributes file so that checked out code can still have platform dependent 
> line endings. 
> More readings: 
> https://help.github.com/articles/dealing-with-line-endings
> http://stackoverflow.com/questions/170961/whats-the-best-crlf-handling-strategy-with-git



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to