[
https://issues.apache.org/jira/browse/ZOOKEEPER-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13886527#comment-13886527
]
Rakesh R commented on ZOOKEEPER-1872:
-------------------------------------
bq.The changes you propose look good, the only small change I'd like to suggest
is that since we are adding a try block, we might as well catch the exception
and fail. What do you think, Rakesh R?
I think catching exception and explicitly failing will not make much
difference, anyway these exceptions will thrown out and fail the test case. If
requires am happy to rebase it.
Ah in trunk some more places like LeaderSessionTrackerTest#testCreateEphemeral
needs to close the quorum. I'll have a closer look once again.
> QuorumPeer is not shutdown in few cases
> ---------------------------------------
>
> Key: ZOOKEEPER-1872
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1872
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Rakesh R
> Assignee: Rakesh R
> Labels: test
> Fix For: 3.4.6, 3.5.0
>
> Attachments: ZOOKEEPER-1872.patch, ZOOKEEPER-1872.patch,
> ZOOKEEPER-1872_br3_4.patch
>
>
> Few cases are leaving quorumpeer running after the test case execution. Needs
> proper teardown for these.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
