[
https://issues.apache.org/jira/browse/ZOOKEEPER-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13941987#comment-13941987
]
Hadoop QA commented on ZOOKEEPER-1870:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12635811/ZOOKEEPER-1870.patch
against trunk revision 1577756.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1970//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1970//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1970//console
This message is automatically generated.
> flakey test in StandaloneDisabledTest.startSingleServerTest
> -----------------------------------------------------------
>
> Key: ZOOKEEPER-1870
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1870
> Project: ZooKeeper
> Issue Type: Bug
> Components: tests
> Affects Versions: 3.5.0
> Reporter: Patrick Hunt
> Assignee: Helen Hastings
> Priority: Critical
> Attachments: ZOOKEEPER-1870.patch, ZOOKEEPER-1870.patch, test.log
>
>
> I'm seeing lots of the following failure. Seems like a flakey test (passes
> every so often).
> {noformat}
> junit.framework.AssertionFailedError: client could not connect to
> reestablished quorum: giving up after 30+ seconds.
> at
> org.apache.zookeeper.test.ReconfigTest.testNormalOperation(ReconfigTest.java:143)
> at
> org.apache.zookeeper.server.quorum.StandaloneDisabledTest.startSingleServerTest(StandaloneDisabledTest.java:75)
> at
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
> {noformat}
> I've found 3 problems:
> 1. QuorumCnxManager.Listener.run() leaks the socket depending on when the
> shutdown flag gets set.
> 2. QuorumCnxManager.halt() doesn't wait for the listener to terminate.
> 3. QuorumPeer.shuttingDownLE flag doesn't get reset when restarting the
> leader election.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
