[
https://issues.apache.org/jira/browse/ZOOKEEPER-1904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948072#comment-13948072
]
Raul Gutierrez Segales commented on ZOOKEEPER-1904:
---------------------------------------------------
I see, thanks for the clarification [~rakeshr]. It mostly makes sense to me, I
have two questions though:
0) In pauseCnxn(), you are adding:
{noformat}
+
+ try {
+ initiatedPause.await(ms, TimeUnit.MILLISECONDS);
+ } catch (InterruptedException e) {
+ e.printStackTrace();
+ }
{noformat}
Should we have pauseCnxn() return the result of await() and then have the test
fail if that is false? I think it would make it easier to understand what's
going on if we communicate if pauseCnxn() failed or not and then have tests act
upon that.
1) and along with that change, the sleep after pauseCnxn():
{noformat}
zk.pauseCnxn(3000);
Thread.sleep(50);
{noformat}
wouldn't be needed anymore, right?
Thoughts?
> WatcherTest#testWatchAutoResetWithPending is failing
> ----------------------------------------------------
>
> Key: ZOOKEEPER-1904
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1904
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: tests
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 3.4.7
>
> Attachments: ZOOKEEPER-1904.patch, ZOOKEEPER-1904.patch
>
>
> Following is the stacktrace taken from [Build :
> ZooKeeper-3.4-WinVS2008_java/465|https://builds.apache.org/job/ZooKeeper-3.4-WinVS2008_java/465/]
> {code}
> [junit] 2014-03-19 09:28:50,020 [myid:] - INFO
> [main-SendThread(127.0.0.1:11278):ClientCnxn$SendThread@975] - Opening socket
> connection to server 127.0.0.1/127.0.0.1:11278. Will not attempt to
> authenticate using SASL (unknown error)
> [junit] 2014-03-19 09:28:51,025 [myid:] - WARN
> [main-SendThread(127.0.0.1:11278):ClientCnxn$SendThread@1102] - Session
> 0x144d9ab1f9e0000 for server null, unexpected error, closing socket
> connection and attempting reconnect
> [junit] java.net.ConnectException: Connection refused: no further
> information
> [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
> [junit] at
> sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:701)
> [junit] at
> org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:361)
> [junit] at
> org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1081)
> [junit] 2014-03-19 09:28:52,661 [myid:] - INFO
> [main-SendThread(127.0.0.1:11278):ClientCnxn$SendThread@975] - Opening socket
> connection to server 127.0.0.1/127.0.0.1:11278. Will not attempt to
> authenticate using SASL (unknown error)
> [junit] 2014-03-19 09:28:53,640 [myid:] - WARN
> [main-SendThread(127.0.0.1:11278):ClientCnxn$SendThread@1102] - Session
> 0x144d9ab1f9e0000 for server null, unexpected error, closing socket
> connection and attempting reconnect
> [junit] java.net.ConnectException: Connection refused: no further
> information
> [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
> [junit] at
> sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:701)
> [junit] at
> org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:361)
> [junit] at
> org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1081)
> [junit] 2014-03-19 09:28:55,435 [myid:] - INFO
> [main-SendThread(127.0.0.1:11278):ClientCnxn$SendThread@975] - Opening socket
> connection to server 127.0.0.1/127.0.0.1:11278. Will not attempt to
> authenticate using SASL (unknown error)
> [junit] 2014-03-19 09:28:56,111 [myid:] - INFO
> [main:JUnit4ZKTestRunner$LoggedInvokeMethod@62] - TEST METHOD FAILED
> testWatchAutoResetWithPending
> [junit] java.util.concurrent.TimeoutException: Did not disconnect
> [junit] at
> org.apache.zookeeper.test.ClientBase$CountdownWatcher.waitForDisconnected(ClientBase.java:145)
> [junit] at
> org.apache.zookeeper.test.WatcherTest.testWatchAutoResetWithPending(WatcherTest.java:202)
> [junit] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
