[
https://issues.apache.org/jira/browse/ZOOKEEPER-1797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951184#comment-13951184
]
Hadoop QA commented on ZOOKEEPER-1797:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12637457/ZOOKEEPER-1797.patch
against trunk revision 1582572.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1993//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1993//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1993//console
This message is automatically generated.
> PurgeTxnLog may delete data logs during roll
> --------------------------------------------
>
> Key: ZOOKEEPER-1797
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1797
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.4.5
> Reporter: Derek Dagit
> Assignee: Rakesh R
> Priority: Blocker
> Fix For: 3.4.7, 3.5.0
>
> Attachments: ZOOKEEPER-1797.patch, ZOOKEEPER-1797.patch
>
>
> org.apache.zookeeper.server.PurgeTxnLog deletes old data logs and snapshots,
> keeping the newest N snapshots and any data logs that have been written since
> the snapshot.
> It does this by listing the available snapshots & logs and creates a
> blacklist of snapshots and logs that should not be deleted. Then, it
> searches for and deletes all logs and snapshots that are not in this list.
> It appears that if logs are rolling or a new snapshot is created during this
> process, then these newer files will be unintentionally deleted.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
