----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19794/#review38971 -----------------------------------------------------------
The patch looks great overall. I just had a few minor nitpicks. ./src/java/main/org/apache/zookeeper/server/PurgeTxnLog.java <https://reviews.apache.org/r/19794/#comment71351> nit: trailing space ./src/java/main/org/apache/zookeeper/server/PurgeTxnLog.java <https://reviews.apache.org/r/19794/#comment71356> We should probably define final strings for "snapshot" and "log". ./src/java/test/org/apache/zookeeper/test/PurgeTxnTest.java <https://reviews.apache.org/r/19794/#comment71352> nit: trailing space - michim On March 28, 2014, 6:42 p.m., Rakesh R wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19794/ > ----------------------------------------------------------- > > (Updated March 28, 2014, 6:42 p.m.) > > > Review request for zookeeper, fpj, michim, Raul Gutierrez Segales, and > Camille Fournier. > > > Bugs: ZOOKEEPER-1797 > https://issues.apache.org/jira/browse/ZOOKEEPER-1797 > > > Repository: zookeeper > > > Description > ------- > > PurgeTxnLog may delete data logs if logs are rolling or a new snapshot is > created during this process > > > Diffs > ----- > > ./src/java/main/org/apache/zookeeper/server/PurgeTxnLog.java 1581683 > ./src/java/test/org/apache/zookeeper/test/PurgeTxnTest.java 1581683 > > Diff: https://reviews.apache.org/r/19794/diff/ > > > Testing > ------- > > I've tried to add a tests > > > Thanks, > > Rakesh R > >
